Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
MNT: Use '--pytest-test-first' option for naming clarity#23341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
tacaswell merged 1 commit intomatplotlib:mainfrommatthewfeickert:mnt/use-pytest-first-option-for-clarityJun 24, 2022
Merged
MNT: Use '--pytest-test-first' option for naming clarity#23341
tacaswell merged 1 commit intomatplotlib:mainfrommatthewfeickert:mnt/use-pytest-first-option-for-clarityJun 24, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
* Use '--pytest-test-first' option over '--django' for name-test-tests forgreater clarity of convention.* Amends PR 23213
tacaswell approved these changesJun 24, 2022
This only affects the pre-commit config and those test have already passed. Merging on a single review. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
--pytest-test-first
option over--django
for name-test-tests for greater clarity of convention. While this commit is somewhat trivial (there is no change in functionality) I personally think that as a developer havingpytest
in the option name makes more sense as it is enforcing thepytest
default style of naming convention (and matplotlib doesn't use Django).pre-commit/pre-commit-hooks
v4.3.0
when I made PRDEV: Add name-tests-test to pre-commit hooks #23213 otherwise I would have just applied it then. Sorry about that.For further reference see:
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).