Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
DOC: Fix version switcher links to documentation#23225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
I'm not sure I understand the CI failures, unfortunately. |
It looks like the pydata theme also deprecated the logo link and replaced it with a logo dictionary that can be filled now. So, I think this needs to be updated to that new format: Line 332 inc7defd7
|
I think the other change ispydata/pydata-sphinx-theme#698 I'll push a commit. Do we need to pin pydata-sphinx very far forward (or back)? On one hand it is a pure-python doc-build-only dependency, on the other adding / changing dependencies on the docs builds can still be harsh on our down-stream packagers. |
Looks like we will have to update the CSS, probably in mpl-sphinx-theme to get back the 'C0' section headers.
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free tosuggest an improvement. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free tosuggest an improvement. |
Thanks folks! Let me know if there's any follow up I can pick up. |
pydata-sphinx-theme 0.9.0 has some pretty major changes in how css gets handled, most of which are marked as beta. I'm not sure we should be switching to it just yet. Probably discuss atmatplotlib/mpl-sphinx-theme#32 |
PR Summary
Closes#23193 by adding a URL field to the version switcher json file. This isnew in pydata-sphinx-theme
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).