Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix draw_idle reference in NavigationToolbar2#2319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mdboom merged 1 commit intomatplotlib:masterfromtacaswell:draw_idle_fix
Aug 28, 2013

Conversation

tacaswell
Copy link
Member

NavigationToolbar2 sub-classes do not (all?) have a draw_idle method (strictly speaking, the QT one does not). I assume this should have bounce strait to the canvas, not through theNavigationToolbar2.draw() method.

Change introduced in25ff2f7

NavigationToolbar2 sub-classes do not (all?) have a draw_idle method (strictly speaking, the QT one does not).  I assume this should have bounce strait to the canvas, not through the `NavigationToolbar2.draw()` method.Change introduced in25ff2f7
@tacaswell
Copy link
MemberAuthor

@mdboom Can you take a look at this?

Sorry to be a pest.

@mdboom
Copy link
Member

Pest away! matplotlib issues are too much of a fire hose for me to keep on top of everything 😉

Looks good to me. And just for completeness -- these are the steps to reproduce:

In the Qt backend, pan and/or zoom to a new position, then push the back button.

mdboom added a commit that referenced this pull requestAug 28, 2013
fix draw_idle reference in  NavigationToolbar2
@mdboommdboom merged commit161c02b intomatplotlib:masterAug 28, 2013
@tacaswell
Copy link
MemberAuthor

Thanks. Sorry for not including better details.

@tacaswelltacaswell deleted the draw_idle_fix branchAugust 28, 2013 15:31
@dmcdougall
Copy link
Member

@mdboom Should this be picked intov1.3.x too?

@mdboom
Copy link
Member

I think this bug was introduced in25ff2f7 which is only on master.

mdboom added a commit that referenced this pull requestSep 17, 2013
fix draw_idle reference in  NavigationToolbar2
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@tacaswell@mdboom@dmcdougall

[8]ページ先頭

©2009-2025 Movatter.jp