Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Init FigureCanvasAgg._lastKey in__init__.#23181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
It looks like not all of the sub-classes call super in init. |
So, still approve, but we need to fix the sub-classes |
This avoids the need for getattr checks. We explicitly don't do thesame for FigureCanvasAgg.renderer because 1) if _lastKey has been set toa non-None value, then renderer has also been set and 2) initingrenderer to e.g. None would change the possible types of a publicattribute.
Ah, let's just init this at the class level then to not make the super() call a requirement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is clearer as well as simpler.
This avoids the need for getattr checks. We explicitly don't do the
same for FigureCanvasAgg.renderer because 1) if _lastKey has been set to
a non-None value, then renderer has also been set and 2) initing
renderer to e.g. None would change the possible types of a public
attribute.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).