Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add legend handler for Annotation#23160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
oscargus wants to merge2 commits intomatplotlib:main
base:main
Choose a base branch
Loading
fromoscargus:legendannotate

Conversation

oscargus
Copy link
Member

@oscargusoscargus commentedMay 29, 2022
edited
Loading

PR Summary

Turned out to be very hard to rebase#13034 so I've cherry-picked the relevant commits and fixed the style comments. Edit: realized that#13034 was heavily based on#10688 so I've added@magedhennawy as coauthor as well.

Closes#13034
Fixes#8236

A problem here is when an annotation is added, but no arrow is given, it will break. Not sure what is expected to happen in this case. Providing a better exception is easy, something like "An annotation must have an arrow if a label is provided" while creating the annotation, but maybe better to get an empty patch in the legend?

Adding an annotation with a label, but no arrow will lead to an empty patch. In#13034 it was not handled (gave an error).

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

eccyan reacted with thumbs up emoji
@oscargusoscargus changed the titleAdd legend handler for Annotation andAdd legend handler for AnnotationMay 29, 2022
@oscargusoscargusforce-pushed thelegendannotate branch 3 times, most recently from5e1b5fe tob2d38a2CompareMay 29, 2022 16:03
Wojciech-Langeand others added2 commitsMay 29, 2022 18:29
Co-authored-by: Maged Hennawy <magedhennawy@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Legend does not show 'annotate'
2 participants
@oscargus@Wojciech-Lange

[8]ページ先頭

©2009-2025 Movatter.jp