Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Drop pytest warning config in nightly tests#23130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Apparently, NumPy or whatever dependency has fixed the warnings that weneeded to ignore. And having this file is causing pytest to drop someconfig we used to have, making it load files we don't want.
Actually, looking a bit closer, I see warnings from Locally, I see And then also turn warnings into errors in the nightly build (by mostly reverting this PR), so we catch things from upstream? |
After some further investigation, I think I see the reason for the inconsistency. For stuff in matplotlib/lib/matplotlib/testing/conftest.py Lines 20 to 25 infb84a0f
We don't have that for What that means is that I'm going to keep the commit above, dropping the |
This prevents it from trying to look at examples or other documentation,some of which may match the test file glob, but won't contain tests.
@@ -0,0 +1,7 @@ | |||
[pytest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't have a strong preference here, but would it make sense to add this to thesetup.cfg
since we already have that? It seems like a lot of configuration stuff is getting put into that andpyproject.toml
s now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let’s for now stick with pytest.ini. Long term this should go into pyproject.toml. However creating it only for pytest may be a bit confusing. Setup.cfg is not really recommended for pytesthttps://docs.pytest.org/en/6.2.x/customize.html#setup-cfg.
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
Apparently, NumPy or whatever dependency has fixed the warnings that we needed to ignore.Tests with nightlies enabled seem to be passing just fine.
And having this file is causing pytest to drop some config we used to have, making it load files we don't want.Fixes#23084.
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).