Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Replace the obsolete wx.PySimpleApp in the demo file embedding_in_wx5#2312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Replace wx.PySimpleApp with wx.Appto avoid the DeprecationWarning.
efiring commentedAug 19, 2013
Would you make the same change in backend_wx.py, please? It would also be nicer to use False rather than 0 as the argument. |
vbr commentedAug 19, 2013
I just submited a PR to backend_wx.py I couldn't find any official specification, but a comment from the creator of wxpython Robin Dunn suggest, that it shouldn't matter since approximately wxpython 2.6 in 2005. The DeprecationWarning was added in wxpython 2.9. Sorry for my ignorance, but how am I supposed to edit my previous pull request to change 0 to False, as suggested? Or should I maybe submit it again in the updated form? (It is of course appropriate, I somehow happened to respect the style of the older example files.) |
efiring commentedAug 19, 2013
@vbr, the usual way to edit a PR is to make the change in your local clone and then force-push (that is, include the "-f" option when pushing) to your github branch. The revision will then appear in your PR automatically. The idea here is that you will have edited your local clone branch via history rewriting, such as by using "git rebase --interactive". |
dmcdougall commentedAug 19, 2013
Resolved by#2316. |
vbr commentedAug 20, 2013
2013/8/19 Eric Firingnotifications@github.com
|
Replace wx.PySimpleApp with wx.App
to avoid the wxPyDeprecationWarning.