Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Replace the obsolete wx.PySimpleApp in the demo file embedding_in_wx5#2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
vbr wants to merge1 commit intomatplotlib:masterfromvbr:patch-5

Conversation

@vbr
Copy link
Contributor

@vbrvbr commentedAug 19, 2013

Replace wx.PySimpleApp with wx.App
to avoid the wxPyDeprecationWarning.

Replace wx.PySimpleApp with wx.Appto avoid the DeprecationWarning.
@efiring
Copy link
Member

Would you make the same change in backend_wx.py, please? It would also be nicer to use False rather than 0 as the argument.
Is there any information available as to when it became safe to replace PySimpleApp? Right now we check only for version >= 2.8; would we need to be more restrictive?

@vbr
Copy link
ContributorAuthor

vbr commentedAug 19, 2013

I just submited a PR to backend_wx.py
#2316
I believe, for wxpython >= 2.8 this change should be safe

I couldn't find any official specification, but a comment from the creator of wxpython Robin Dunn
http://wxpython-users.1045709.n5.nabble.com/wx-App-vs-wx-PySimpleApp-td2316148.html

suggest, that it shouldn't matter since approximately wxpython 2.6 in 2005.

The DeprecationWarning was added in wxpython 2.9.

Sorry for my ignorance, but how am I supposed to edit my previous pull request to change 0 to False, as suggested? Or should I maybe submit it again in the updated form? (It is of course appropriate, I somehow happened to respect the style of the older example files.)
vbr

@efiring
Copy link
Member

@vbr, the usual way to edit a PR is to make the change in your local clone and then force-push (that is, include the "-f" option when pushing) to your github branch. The revision will then appear in your PR automatically.

The idea here is that you will have edited your local clone branch via history rewriting, such as by using "git rebase --interactive".

@dmcdougall
Copy link
Member

Resolved by#2316.

@vbr
Copy link
ContributorAuthor

vbr commentedAug 20, 2013

2013/8/19 Eric Firingnotifications@github.com

@vbrhttps://github.com/vbr, the usual way to edit a PR is to make the
change in your local clone and then force-push (that is, include the "-f"
option when pushing) to your github branch. The revision will then appear
in your PR automatically.

The idea here is that you will have edited your local clone branch via
history rewriting, such as by using "git rebase --interactive".


Reply to this email directly or view it on GitHubhttps://github.com//pull/2312#issuecomment-22904111
.

Thanks for the recommendation, and sorry for further request on this
trivial issue.
Is the mentioned way of editing possible in the web interface of github, I
am now trying to use (also for the previous PR)? (Unfortunately I couldn't
find any similar editable form of the edit on the github page. I only found
a possibility to commit it as a new change, which would likely be
confusing.
Is it possibly due to the closing the issue in the meantime?)
Or is some desktop client necessarily needed to work with a downloaded
local copy?
vbr

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vbr@efiring@dmcdougall

[8]ページ先頭

©2009-2025 Movatter.jp