NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Fix wrong binding of JS this#2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

andreabedini wants to merge1 commit intomatplotlib:masterfromandreabedini:patch-1

Closed

Fix wrong binding of JS this#2310

andreabedini wants to merge1 commit intomatplotlib:masterfromandreabedini:patch-1

Conversation

Copy link

andreabedini commentedAug 19, 2013

inside the closure this binds to the WebSocket object rather than to the figure object. I only briefly tested this but its meaning should be apparent.

Fix wrong binding of JS this

0e2bfca

inside the closure this binds to the WebSocket object rather than to the figure object.

Copy link

Member

pelson commentedAug 19, 2013

Looks fine.@mdboom, would you mind taking a look and merging?

Copy link

Member

mdboom commentedAug 21, 2013

Thanks. This looks good. I'll test and merge when I get back from vacation next week.

Copy link

Member

Thanks for finding this. I was stumped as to why the onload handler wasn't working. I'm reviving#2054, which is a pretty major refactor of the javascript, so I think it best to just address this and test this there, which I hope to have in a mergeable state soon.