NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

TST: Add some tests for QuadMesh contains function#22967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

timhoffm merged 1 commit intomatplotlib:mainfromgreglucas:tst-quadmesh-cursor

May 5, 2022

Merged

TST: Add some tests for QuadMesh contains function#22967

timhoffm merged 1 commit intomatplotlib:mainfromgreglucas:tst-quadmesh-cursor

May 5, 2022

Conversation

Copy link

Contributor

greglucas commentedMay 4, 2022

PR Summary

As noted in#22957 (comment) it would be nice to have a few more tests for the contains of QuadMesh.

Update QuadMesh.get_cursor_data to handle multiple contains hits
Test that an empty array doesn't return any cursor_data
Test a few points in a standard QuadMesh
Test points within and around a concave QuadMesh

PR Checklist

Tests and Styling

Has pytest style unit tests (andpytest passes).
IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

[N/A] New features are documented, with examples if plot related.
[N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
[N/A] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
[N/A] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

TST: Add some tests for QuadMesh contains function

887eb62

* Update QuadMesh.get_cursor_data to handle multiple contains hits* Test that an empty array doesn't return any cursor_data* Test a few points in a standard QuadMesh* Test points within and around a concave QuadMesh