Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix "is" comparison for np.array#22957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

raphaelquast
Copy link
Contributor

@raphaelquastraphaelquast commentedMay 2, 2022•
edited
Loading

PR Summary

fixes incorrect check if numpy array is none.

  • if x fails for numpy arrays due to array-broadcasting!
  • if x is None does what it should...

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

@raphaelquastraphaelquast mentioned this pull requestMay 2, 2022
6 tasks
@timhoffmtimhoffm added this to thev3.5.2 milestoneMay 2, 2022
@greglucas
Copy link
Contributor

It would be nice to get a test for this too, so we don't hit this path again on accident.

I just put up some tests for another PR#22955 in thecontains() portion of the code:6c22e86
A similar test or two could be added here for theget_cursor_data() function.

tacaswell, timhoffm, and oscargus reacted with thumbs up emoji

@QuLogic
Copy link
Member

Feel free to open a followup with the test; I want to merge to get 3.5.2 out.

@QuLogicQuLogic merged commit2aa71eb intomatplotlib:mainMay 2, 2022
@QuLogic
Copy link
Member

meeseeksdev backport to v3.5.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMay 2, 2022
QuLogic added a commit that referenced this pull requestMay 2, 2022
…957-on-v3.5.xBackport PR#22957 on branch v3.5.x (fix "is" comparison for np.array)
@raphaelquastraphaelquast deleted the fix_QuadMesh_cursor_data branchDecember 5, 2022 09:24
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.2
Development

Successfully merging this pull request may close these issues.

4 participants
@raphaelquast@greglucas@QuLogic@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp