Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Missingf prefix on f-strings fix#22884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Missingf prefix on f-strings fix#22884
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
I have mixed feelings about PRs from bots (?) but this fix is correct and I see no reason not to take it. |
May be better to merge#22883 though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should we merge this for 3.5.2 and#22883 for 3.6.0?
(Feel free to merge once decided.)
The problem is not in 3.5.2 so I changed to 3.6 for this, which leads to closing this and merging#22883 instead. |
code-review-doctor commentedApr 24, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@tacaswell I'm really a person that found a bug via a static analysis bot I wrote. FWIW I checked 666 of the most popular python repos on GitHub and found 73 repos that had this issue. I then ran my script that auto-creates the issues in GitHub then auto-creates the PR to fix the issues. Half bot half human I guess :) |
@code-review-doctor Sorry, when I clicked through the profile I jumped to conclusions 🐑 This found a real bug and even though we fixed it differently, we appreciate the PR and hope to hear from you again! |
Fixes#22882