Redo of#19201 (decrease size of mathtext svg baselines, by switching to embedding text as text, not as paths), but without removing the other formats or restricting fonts. Suggested as a preliminary to#22852 (which would just need to move the affected tests to the newsvgastext_math_tests list.

Intentionally contains an example test in a second commit, which is reverted by the third commit: checkout the second commit to test locally. I will remove these two commits from history (and hence get rid of the "unclean PR" lint) if this PR gets approved.

PR Checklist

Tests and Styling

Has pytest style unit tests (andpytest passes).
IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

New features are documented, with examples if plot related.
New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

This reverts commitce14a1b.

anntzer added topic: testing topic: text/mathtext labels

Apr 23, 2022

anntzer mentioned this pull request

Apr 23, 2022

Implement TeX's fraction alignment for Mathtext fractions#22852

Closed

3 tasks

oscargus approved these changes

May 7, 2022

View reviewed changes

jklymak reviewed

May 18, 2022

View reviewed changes

Copy link

Member

jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I guess I'm no clear on this - how do we normally embed fonts in SVGs? If as shapes, then shouldn't we test that?

Copy link

ContributorAuthor

anntzer commentedMay 18, 2022

As paths, but all the existing mathtext tests already test that. The point is not to convert the old tests to embed-as-glyphs (which would indeed affect the testing of the embed-as-shape path), but to make the new ones use the embed-as-glyphs codepath. If we ever get to a point where all the old tests have been removed (seems unlikely), we can always rediscuss how to restore some embed-as-paths tests.

Copy link

Member

jklymak commentedMay 18, 2022

OK, but I don't understand the motivation, other than a moderate optimization of the repo size. If we embed paths, that seems to be what we should test, even for new tests.

Copy link

Member

timhoffm commentedMay 18, 2022

I think most of the time,we're not interested in testing the shape of the glyph path (and the algorithm of that). This glyph should be in that position is enough, and potentially more stable. If the path generation changes all tests would be broken even when the are testing primarily other aspects.

Copy link

ContributorAuthor

anntzer commentedJun 11, 2022•
edited
Loading

@jklymak Are you happy with the explanation given by@timhoffm (which I agree with) and willing to merge this? (If you approve this, I will squash out the second and third commits, which are making the pr_clean check fail -- see top message.)