Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
fix and test deprecated layout method toggling#22849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Just a heads up that I cannot review anything properly for a week or so. Thanks! |
Is None the "null"-layout engine? It looks like there is also mention of the string "none" here: |
Any interest in doing this for 3.5.3 and saving#22452 for 3.6.0? |
Sorry, I missed this entirely until I saw it was closed! In the future, please err on the side of re-milestoning things back if you want them to be in a bug fix release. The reason#22452 picked up all of the extra complexity is that just setting it back to None could end up breaking the colorbars so I would still be wary of this fix. |
Re-uses the tests frommatplotlib#22849, but also tests that going _back_ on worksas well.Fixesmatplotlib#22847Co-authored-by: richardsheridan <richard.sheridan@gmail.com>
Re-uses the tests frommatplotlib#22849, but also tests that going _back_ on worksas well.Fixesmatplotlib#22847Co-authored-by: richardsheridan <richard.sheridan@gmail.com>
PR Summary
Fixes#22847. Not sure if there are knock-on effects, looking forward to code review.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).