Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix Tk error when updating toolbar checkbutton images#22841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:mainfromdaniilS:tk_toolbar_colours_fix
Apr 14, 2022

Conversation

daniilS
Copy link
Contributor

PR Summary

Fixes#22836 introduced in#22163

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • N/A] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

richardsheridan reacted with eyes emoji
Copy link
Member

@tacaswelltacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code looks reasonable, but someone who has a dark-themed desktop should manually test this before it gets merged!

Copy link
Contributor

@richardsheridanrichardsheridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I manually checked the dpi change error and the dark-mode behavior and it looks good to go

@QuLogicQuLogic merged commit4e20f15 intomatplotlib:mainApr 14, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@richardsheridanrichardsheridanrichardsheridan approved these changes

Assignees

@richardsheridanrichardsheridan

Labels
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

[Bug]: TclError raised by _set_image_for_button() when _update_window_dpi() runs
5 participants
@daniilS@tacaswell@richardsheridan@QuLogic@oscargus
[8]ページ先頭
©2009-2025 Movatter.jp