Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FIX: callback for subfigure uses parent#22806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

jklymak
Copy link
Member

PR Summary

Closes#22804

Not clear that SubFigures shouldn't get their own callback -@anntzer and@greglucas better understand how these work or what the right scope should be.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

@anntzer
Copy link
Contributor

Does this really help#22804 (other than hiding the AttributeError)? I don't think dpi_changed will be correctly called on the subfigure, right?

@jklymak
Copy link
MemberAuthor

I'm not sure. I thought this just updated the artist if the dpi changes. That can be handled at the parent level I think. However I didn't too carefully trace this through and the original issue wasn't clear on how big the arrow should be etc. Testing on the fly dpi changes is not easy I think.

@jklymak
Copy link
MemberAuthor

I think this is still OK for#22804, though I prefer you removing the callback for quiver#22807. The only callback we allow isdpi_changed (and it was only used in quiver) so I think its correct to just fallback to the parent figure callback if someone else has used this callback for something.

@jklymakjklymak marked this pull request as ready for reviewApril 9, 2022 07:20
@anntzer
Copy link
Contributor

Ah, sorry I misread. Yes this looks good (even if we may want to deprecate this later).

@greglucasgreglucas merged commit5937c68 intomatplotlib:mainApr 9, 2022
@QuLogicQuLogic modified the milestones:v3.6.0,v3.5.2Apr 11, 2022
@QuLogic
Copy link
Member

@meeseeksdev backport to v3.5.x

@lumberbot-app
Copy link

Could not push to auto-backport-of-pr-22806-on-v3.5.x due to error, aborting.

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestApr 11, 2022
@QuLogic
Copy link
Member

@meeseeksdev backport to v3.5.x

@lumberbot-app
Copy link

Could not push to auto-backport-of-pr-22806-on-v3.5.x due to error, aborting.

@QuLogic
Copy link
Member

meeseeksdev backport to v3.5.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestApr 13, 2022
oscargus added a commit that referenced this pull requestApr 13, 2022
…806-on-v3.5.xBackport PR#22806 on branch v3.5.x (FIX: callback for subfigure uses parent)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer approved these changes

@greglucasgreglucasgreglucas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.2
Development

Successfully merging this pull request may close these issues.

[Bug]: Quiver not working with subfigure?
4 participants
@jklymak@anntzer@QuLogic@greglucas
[8]ページ先頭
©2009-2025 Movatter.jp