Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
MNT: Skip existing wheels during nightly wheel upload#22759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
MNT: Skip existing wheels during nightly wheel upload#22759
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Add the '--skip-existing' option for anaconda upload to> Skip errors on package batch upload if it already existsThis will keep the nightlies.yml workflow from erroring out ifno new wheels were generated, or if a workflow is manually rerun.Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
As anaconda-client does not have any stable releases on PyPI thatsupport the API desired for uploads, pin it to the last commit onhttps://github.com/Anaconda-Platform/anaconda-client known toinstall and work (which is the merge commit ofAnaconda-Platform/anaconda-client PR 589). This is done for APIstability.
38cb779 to4599e81Compare| python -m pip install --upgrade pip setuptools wheel | ||
| # c.f. https://github.com/Anaconda-Platform/anaconda-client/issues/540 | ||
| python -m pip install git+https://github.com/Anaconda-Server/anaconda-client | ||
| python -m pip install git+https://github.com/Anaconda-Server/anaconda-client@be1e14936a8e947da94d026c990715f0596d7043 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
While this does run the risk of things breaking if this commit were to ever be removed from history, pinning it to something seems much safer then having an API break happen with no warning.
tacaswell commentedApr 1, 2022
I do not think we need the wheel building to run on this PR because it is only looking at artifacts it finds on the main branch, not actually making them. |
matthewfeickert commentedApr 1, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Correct. Thanks Thomas! |
matthewfeickert commentedApr 3, 2022
Thanks for the fast review@tacaswell and fast merge@oscargus! Now that this is in and should get applied for the first time in the scheduled run tonight (2022-04-03), do you have thoughts on the curation/removal of old nightly wheels as described in#22757 (comment)? |
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
Resolves#22757
Amends PR#22733
Add the
--skip-existingoption foranaconda uploadtoThis will keep the
nightlies.ymlworkflow from erroring out if no new wheels were generated, or if a workflow is manually rerun.As
anaconda-clientdoes not have any stable releases on PyPI that support the API desired for uploads (c.f.anaconda/anaconda-client#540), pin it to the last commit onhttps://github.com/Anaconda-Platform/anaconda-client known to install and work (which is the merge commit ofanaconda/anaconda-client#589). This is done for API stability.PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).