Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Added clim support to tripcolor#22734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

andrew-fennell
Copy link
Contributor

@andrew-fennellandrew-fennell commentedMar 30, 2022•
edited
Loading

PR Summary

tripcolor was ignoringclim input.

Added parameters to collection instantiations in tripcolor to ensure that all parameters are being handled properly (includingkwargs).

Closes#22726

Example code:

from pylab import *x, y, z = np.random.rand(100), np.random.rand(100), np.random.rand(100)tripcolor(x, y, z, clim=(0.25, 0.75))colorbar()show()

Incorrect output

image

Correct output

image

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

@andrew-fennell
Copy link
ContributorAuthor

I don't think randomness is encouraged in testing, but I am not very familiar with how to test some components.

If anyone has any advice or suggestions, I would appreciate it!

@andrew-fennellandrew-fennellforce-pushed thetripcolor-clim-support branch 3 times, most recently fromd6d0910 to2e1033aCompareMarch 30, 2022 21:38
Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Modulo one minor indentation issue.

@jklymak
Copy link
Member

I don't think randomness is encouraged in testing,

You've added a seed, so it is no longer "random"!

@jklymakjklymak added this to thev3.6.0 milestoneMar 31, 2022
@jklymakjklymak merged commitee5d9c4 intomatplotlib:mainMar 31, 2022
@jklymak
Copy link
Member

Thanks@andrew-fennell !

andrew-fennell reacted with laugh emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

[Bug]: tripcolor ignores clim
3 participants
@andrew-fennell@jklymak@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp