Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Small style fixes.#22721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Small style fixes.#22721
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Affine2D() | ||
.scale(1.0,-1.0) | ||
.translate(0.0,self.height)) | ||
returntransform+Affine2D().scale(1,-1).translate(0,self.height) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The multi-line version is arguably more readable but not going to block over that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
+/-0
Affine2D() | ||
.scale(1.0,-1.0) | ||
.translate(0.0,self.height)) | ||
returntransform+Affine2D().scale(1,-1).translate(0,self.height) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
+/-0
@tacaswell you‘re milestoneing this as 3.7. have we already branched of 3.6? |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
We have not yet branched 3.6 off from main, so the canoncial target is 3.6.0. |
I miss-clicked, but I did make the 3.7 milestone for stuff we know we want to push out. |
PR Summary
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).