Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Use repr in error messages#22712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromoscargus:reprinerrors
Apr 7, 2022
Merged

Conversation

oscargus
Copy link
Member

@oscargusoscargus commentedMar 27, 2022•
edited
Loading

PR Summary

Related to#21959

Added tests for some of the errors.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

@oscargusoscargus marked this pull request as draftMarch 28, 2022 06:08
@oscargusoscargusforce-pushed thereprinerrors branch 5 times, most recently from2c8c6c9 to985c73dCompareMarch 28, 2022 11:19
@oscargusoscargus marked this pull request as ready for reviewMarch 28, 2022 11:34
@oscargusoscargus mentioned this pull requestMar 29, 2022
6 tasks
@oscargusoscargusforce-pushed thereprinerrors branch 2 times, most recently from3e617ff to498f462CompareMarch 30, 2022 07:33
@oscargusoscargus added this to thev3.6.0 milestoneApr 4, 2022
@matplotlibmatplotlib deleted a comment fromoscargusApr 5, 2022
@QuLogic
Copy link
Member

QuLogic commentedApr 5, 2022•
edited
Loading

@QuLogicQuLogic deleted a comment fromoscargus30 seconds ago

Wait, what? I thought I was deleting a pending comment of mine. I don't know what got deleted now.

@QuLogicQuLogic closed thisApr 5, 2022
@QuLogicQuLogic reopened thisApr 5, 2022
@timhoffm
Copy link
Member

timhoffm commentedApr 7, 2022•
edited
Loading

We'll never know what got deleted ... 🪄

Still this PR looks fine, so I merge as is.

@timhoffmtimhoffm merged commit0e46ff2 intomatplotlib:mainApr 7, 2022
@oscargusoscargus deleted the reprinerrors branchApril 7, 2022 21:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

3 participants
@oscargus@QuLogic@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp