Cannot really see how this can be tested as I do not know of any ttf-font locations on the CI... Edit: I found a ttf-font in the test data, so at least it should be possible to test passing a Path without errors. Edit 2: Test added.

Also added a validation function forfont.stretch, so now rcParam-values can also be ints.

Kept it as four separate commits, but can of course merge to a single.

PR Checklist

Tests and Styling

Has pytest style unit tests (andpytest passes).
IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

New features are documented, with examples if plot related.
New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

oscargus added Documentation topic: text/fonts labels

Mar 3, 2022

oscargus force-pushed thefontmanageraddpathstr branch fromf56ea70 toe22b3a6Compare

March 3, 2022 18:14

oscargus added this to thev3.6.0 milestone

Mar 3, 2022

oscargus force-pushed thefontmanageraddpathstr branch 2 times, most recently from9939784 to22e3dafCompare

March 3, 2022 18:25

QuLogic reviewed

Mar 3, 2022

View reviewed changes

lib/matplotlib/font_manager.py OutdatedShow resolvedHide resolved

oscargus marked this pull request as draft

March 4, 2022 08:05

oscargus force-pushed thefontmanageraddpathstr branch 2 times, most recently from6d5edf6 to63eba3bCompare

March 4, 2022 19:19

oscargus changed the title~~Fix Path/str-discrepancy in FontManager.addpath~~Fix Path/str-discrepancy in FontManager.addpath and improve documentation

Mar 4, 2022

oscargus marked this pull request as ready for review

March 4, 2022 19:40

timhoffm reviewed

Mar 6, 2022

View reviewed changes

Copy link

Member

timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is good, only some stylistic comments.

lib/matplotlib/font_manager.py OutdatedShow resolvedHide resolved

lib/matplotlib/font_manager.py


		- style: Either 'normal' (default), 'italic' or 'oblique'.
		- style: Either 'normal', 'italic' or 'oblique'.

Copy link

Member

timhoffmMar 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Optional: Highlight the properties using italics (or alternatively literal format)

Suggested change

	-style:Either'normal','italic'or'oblique'.
	-style:Either'normal','italic'or'oblique'.

This is also quite redundant with the setters. This is almost completely a data class. IMHO it would be reasonable to add properties and move all the documentation there, i.e. delete this list and the setter docstrings (setters may link to the property docs. But that's for a later time.

Copy link

MemberAuthor

oscargusMar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That would make sense, but I think it is better to try to get the information from the setmethods at a later stage.

lib/matplotlib/tests/test_font_manager.py OutdatedShow resolvedHide resolved

oscargus marked this pull request as draft

March 6, 2022 10:26

oscargus added3 commits

March 14, 2022 10:25

Convert path to str in FontManager.addpath

3656bf9

Improve documentation of FontManager

25d2d55

Add documention for fontManager.Closesmatplotlib#22586

3377656

oscargus force-pushed thefontmanageraddpathstr branch from63eba3b to9e67574Compare

March 14, 2022 09:25

oscargus marked this pull request as ready for review

March 14, 2022 09:27

Copy link

MemberAuthor

oscargus commentedMar 14, 2022•
edited
Loading

I changed based on the comments.

However, there is still the same issue as in#22556 (comment)

Edit: I screwed up when editing and did just amend to the last commit rather than updating the correct one, so one may want to squash.

oscargus force-pushed thefontmanageraddpathstr branch from9e67574 to249f360Compare

March 14, 2022 11:10

timhoffm approved these changes

Mar 15, 2022

View reviewed changes

oscargus force-pushed thefontmanageraddpathstr branch from249f360 to0525305Compare

March 15, 2022 08:22

oscargus commented

Mar 15, 2022

View reviewed changes

lib/matplotlib/font_manager.py

		@@ -1,7 +1,7 @@
		"""
		A module for finding, managing, and using fonts across platforms.

		This module provides a single `FontManager` instance that can
		This module provides a single `FontManager` instance, ``fontManager``, that can