Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Refactor handling of tick and ticklabel visibility in Axis.clear()#22587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:mainfromtimhoffm:refactor-tick-clearing
Mar 16, 2022

Conversation

timhoffm
Copy link
Member

@timhoffmtimhoffm commentedMar 3, 2022
edited
Loading

This is a follow-up to#20826, which makes the exceptions from clearing more explicit.

While being a bit more verbose, this makes it more clear what is going on. Also I think having proper_reset_*_tick_kw methods will make patching the 3D default tick direction for#22517 (comment) easy. Something along the lines (to be tested):

# in axis3d.pyclass Axis(...):    def reset_major_tick_kw(keep_tick_and_label_visibility=False)        super().reset_major_tick_kw(keep_tick_and_label_visibility)        self._major_tick_kw['tickdir'] = 'inout'

The test introduced in#20826 should verify that this solution is equivalent and does not break something.

This is a follow-up tomatplotlib#20826, which makes the exceptions from clearingmore explicit.
@timhoffmtimhoffm added this to thev3.6.0 milestoneMar 3, 2022
@timhoffmtimhoffm mentioned this pull requestMar 3, 2022
Reset major tick params to defaults.

Shared subplots pre-configure tick and label visibility. To keep this
beyond an Axis.clear() operation, we may
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
beyondanAxis.clear()operation,wemay
beyondan`Axis.clear()`operation,wemay

(Or something similar. If possible. For both methods.)

@QuLogicQuLogic merged commit945692c intomatplotlib:mainMar 16, 2022
@timhoffmtimhoffm deleted the refactor-tick-clearing branchJune 10, 2022 21:19
@QuLogicQuLogic changed the titleRefactor handling of tick and ticklabel visiblity in Axis.clear()Refactor handling of tick and ticklabel visibility in Axis.clear()Aug 22, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@oscargusoscargusoscargus approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

3 participants
@timhoffm@QuLogic@oscargus

[8]ページ先頭

©2009-2025 Movatter.jp