Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Refactor handling of tick and ticklabel visibility in Axis.clear()#22587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This is a follow-up tomatplotlib#20826, which makes the exceptions from clearingmore explicit.
Reset major tick params to defaults. | ||
Shared subplots pre-configure tick and label visibility. To keep this | ||
beyond an Axis.clear() operation, we may |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggested change
beyondanAxis.clear()operation,wemay | |
beyondan`Axis.clear()`operation,wemay |
(Or something similar. If possible. For both methods.)
oscargus approved these changesMar 6, 2022
QuLogic approved these changesMar 16, 2022
This was referencedSep 8, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This is a follow-up to#20826, which makes the exceptions from clearing more explicit.
While being a bit more verbose, this makes it more clear what is going on. Also I think having proper
_reset_*_tick_kw
methods will make patching the 3D default tick direction for#22517 (comment) easy. Something along the lines (to be tested):The test introduced in#20826 should verify that this solution is equivalent and does not break something.