Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fixed font prop in text elements in svg figures#22541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

not-so-rabh
Copy link

Fixes#22528

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

Copy link
Member

@QuLogicQuLogic left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This seems fine if the original reporter says it works. I cannot reproduce the issue in Chromium.

@QuLogicQuLogic requested a review fromanntzerMarch 2, 2022 01:38
@anntzer
Copy link
Contributor

I don't think this is correct, e.g.

rcParams["svg.fonttype"] = "none"; figtext(.5, .5, "hello", font="DejaVu Sans"); savefig("/tmp/test.svg")

results in

<text x="230.4" y="172.8" transform="rotate(-0 230.4 172.8)">hello</text>

where the unquoted DejaVu Sans is likely wrong? (at least wrt. the spec)

@anntzeranntzer removed their request for reviewMarch 2, 2022 08:52
@timhoffmtimhoffm added the status: needs clarificationIssues that need more information to resolve. labelApr 5, 2022
@timhoffm
Copy link
Member

@not-so-rabh could you comment on@anntzer's question?

@jklymakjklymak marked this pull request as draftJune 2, 2022 14:24
@jklymak
Copy link
Member

Converted to draft - needs discussion and rebase

@tacaswell
Copy link
Member

tacaswell commentedAug 16, 2022
edited
Loading

The issue that@anntzer points out is real, we need to only add the un-escaped font name if the name is one of the generic names.

There is also some confusion about whatget_name andget_family onFontProperties do.get_family gives back the list of font names (which font tools call families) andget_name turns the crank on our font search code and return the family of the font actually found on the users system.

This line of code also was impacted by#23559 and the fix for#23492 will also touch this line. I think I see how to fix both#22528 and#23492 in one shot and in the interest of trying to squeeze these in for 3.6 am just going to do it.

Thank you for your work on this@not-so-rabh , I apologize for taking this issue from under you, and I hope we hear from you again!

@tacaswell
Copy link
Member

Replaced by#23638

@tacaswelltacaswell added this to theunassigned milestoneSep 1, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Labels
backend: svgstatus: needs clarificationIssues that need more information to resolve.status: needs rebase
Projects
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: problem with font property in text elements of svg figures
7 participants
@not-so-rabh@anntzer@timhoffm@jklymak@tacaswell@QuLogic@oscargus

[8]ページ先頭

©2009-2025 Movatter.jp