Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Simplifications to ToolManager.{add,remove}_tool.#22509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
greglucas merged 1 commit intomatplotlib:mainfromanntzer:tool_addremove
Mar 11, 2022

Conversation

anntzer
Copy link
Contributor

On the addition side, inline ToolManager._tool_added_event. It's used
at a single place, and other events emitted by ToolManager are not split
out into their own helper methods.

On the removal side, deprecate the Tool.destroy handle: it's unused, and
if a tool really wants to know when it's getting removed, it can just
connect to its own tool_removed_event, which can also be used by other
callers.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

On the addition side, inline ToolManager._tool_added_event.  It's usedat a single place, and other events emitted by ToolManager are not splitout into their own helper methods.On the removal side, deprecate the Tool.destroy handle: it's unused, andif a tool really wants to know when it's getting removed, it can justconnect to its own tool_removed_event, which can also be used by othercallers.
@anntzeranntzer added the MEP: MEP22tool manager labelFeb 19, 2022
@anntzeranntzer added this to thev3.6.0 milestoneFeb 19, 2022
@greglucasgreglucas merged commitb9ae51c intomatplotlib:mainMar 11, 2022
@anntzeranntzer deleted the tool_addremove branchMarch 11, 2022 06:58
@anntzeranntzer mentioned this pull requestApr 12, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@oscargusoscargusoscargus approved these changes

@greglucasgreglucasgreglucas approved these changes

Assignees
No one assigned
Labels
MEP: MEP22tool manager
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

3 participants
@anntzer@oscargus@greglucas

[8]ページ先頭

©2009-2025 Movatter.jp