Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Some more maintenance for mathtext internal implementation.#22488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
oscargus approved these changesFeb 18, 2022
Inherit the render() docstring (without even bothering with a "docstringinherited" comment, as that would be as long as the actual docstring,the API is relatively transparent, and the module is private).Inline _determine_order, which, despite what it says, was never directlyused by vpack/hpack, but only in _set_glue. Removing the indirectionallows a more linear reading of _set_glue (which is also not *that*long).Delete unused SubSuperCluster.
timhoffm approved these changesFeb 18, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Inherit the render() docstring (without even bothering with a "docstring
inherited" comment, as that would be as long as the actual docstring,
the API is relatively transparent, and the module is private).
Inline _determine_order, which, despite what it says, was never directly
used by vpack/hpack, but only in _set_glue. Removing the indirection
allows a more linear reading of _set_glue (which is also notthat
long).
Delete unused SubSuperCluster (supposedly done at#22204 (comment)
but I apparently forgot to push that).
Some miscellania.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).