Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Addset_XY andset_data toQuiver#22407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jklymak commentedFeb 5, 2022
The API seems fine, though I wonder about providing the conveniences, versus just |
ianhi commentedFeb 5, 2022
I put in both since
I'm a bit confused. the example changes after some time so since it's displayed already you need to call draw to update it |
jklymak commentedFeb 5, 2022
I dont think of fig.canvas.draw as user-facing. |
ianhi commentedFeb 5, 2022
|
| arrows; their locations are fixed when the class is | ||
| instantiated. Possibly this method will be useful | ||
| in animations. | ||
| The only API methods are ``set_UVC()``, ``set_XY``, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Remove "only"? (Does three count as only?)
Single back-ticks will link, right? I guess one should be consistent with either using() for all or none of the methods.
oscargus commentedFeb 22, 2022
Couldn't comment in the source, but which no longer is correct. |
oscargus commentedDec 9, 2022
I think this would be nice to get into 3.7. Would you have time to update it? I guess one can use the docs of the original Quiver class to explain the U, V, and C arguments in |
ianhi commentedDec 9, 2022
maybe - when is the deadline there? jan 1? Also dependent on figuring out what I meant by:
also
probably won't be able to do that |
| U, V : ??? | ||
| C : ??? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
note to self - this is part of the "cleaning up"
oscargus commentedDec 14, 2022
As I understand it, yes, but with some margins. |
timhoffm commentedDec 14, 2022
We can still do that later. Already having this on |
jklymak commentedJan 24, 2023
@ianhi I'll move to Draft until you have time to come back to this... |
QuLogic commentedMar 13, 2024
This was replaced by#26410. |
PR Summary
Willclose#22402 andclose#11790
still a bit of tidying up to do, and should probably pair with a similar implementation for Barb.
Opening early to get feedback I think I did all the shape setting correctly, but not entirely clear whats happening with all the masking. Also this will enable modifying the number of points and there was originally some concern about that.
Example script:
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).