Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Pin coverage to fix CI#22398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:mainfromQuLogic:pin-coverage
Feb 7, 2022
Merged

Conversation

QuLogic
Copy link
Member

PR Summary

The newly released 6.3.1 is still sporadically failing fromnedbat/coveragepy#1310

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

The newly released 6.3.1 is still sporadically failing fromnedbat/coveragepy#1310
@QuLogicQuLogic added this to thev3.5.2 milestoneFeb 4, 2022
@QuLogic
Copy link
MemberAuthor

For Azure, it looks like the macOS images were updated from 20220124.1 to 20220201.2. I'm not seeing anything specifically about Ghostscript inthe changes. Ghostscript seems to be installed via Homebrew and hasn't changed versions there, but possibly some of its dependencies have.

@QuLogic
Copy link
MemberAuthor

Based on the output from Azure, it appears that Ghostscript is compressing some streams with LZW in binary. This gets somewhat mangled by outputting toStringIO and then trying to encode it to compare against theBytesIO result. I'm not sure we really should be supportingStringIO, or at least disable compression if so.

@anntzer
Copy link
Contributor

I think I agree that saving distiller output to text streams does not make sense (as the postscript standard explicitly allows arbitrary binary sequences (section 3.14 "Binary encoding details"), we just don't output them ourselves. I guess the most backcompatible fix is the one you suggest (to disable distillers when outputting to text, perhaps logging a warning in that case).

Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Approval limited to the coverage part.

@tacaswell
Copy link
Member

I generally dislike hard upper pins, but we will want to do a hard-pin on the 3.5.x branch anyway and it sounds like we are not the only people with this issue.

@tacaswell
Copy link
Member

I'm going to merge this over the GS related failures.

@tacaswelltacaswell merged commit88fc75c intomatplotlib:mainFeb 7, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestFeb 7, 2022
@QuLogicQuLogic deleted the pin-coverage branchFebruary 7, 2022 22:34
@QuLogic
Copy link
MemberAuthor

I generally dislike hard upper pins, but we will want to do a hard-pin on the 3.5.x branch anyway and it sounds like we are not the only people with this issue.

I'm following the upstream issue so I can test unpin when it's fixed,

tacaswell reacted with thumbs up emoji

timhoffm added a commit that referenced this pull requestFeb 8, 2022
…398-on-v3.5.xBackport PR#22398 on branch v3.5.x (Pin coverage to fix CI)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.2
Development

Successfully merging this pull request may close these issues.

4 participants
@QuLogic@anntzer@tacaswell@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp