Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Pin coverage to fix CI#22398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Pin coverage to fix CI#22398
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The newly released 6.3.1 is still sporadically failing fromnedbat/coveragepy#1310
For Azure, it looks like the macOS images were updated from 20220124.1 to 20220201.2. I'm not seeing anything specifically about Ghostscript inthe changes. Ghostscript seems to be installed via Homebrew and hasn't changed versions there, but possibly some of its dependencies have. |
Based on the output from Azure, it appears that Ghostscript is compressing some streams with LZW in binary. This gets somewhat mangled by outputting to |
I think I agree that saving distiller output to text streams does not make sense (as the postscript standard explicitly allows arbitrary binary sequences (section 3.14 "Binary encoding details"), we just don't output them ourselves. I guess the most backcompatible fix is the one you suggest (to disable distillers when outputting to text, perhaps logging a warning in that case). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Approval limited to the coverage part.
Uh oh!
There was an error while loading.Please reload this page.
I generally dislike hard upper pins, but we will want to do a hard-pin on the 3.5.x branch anyway and it sounds like we are not the only people with this issue. |
I'm going to merge this over the GS related failures. |
I'm following the upstream issue so I can test unpin when it's fixed, |
…398-on-v3.5.xBackport PR#22398 on branch v3.5.x (Pin coverage to fix CI)
PR Summary
The newly released 6.3.1 is still sporadically failing fromnedbat/coveragepy#1310
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).