Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
MNT: make layout deprecations pending#22345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
MNT: make layout deprecations pending#22345
Uh oh!
There was an error while loading.Please reload this page.
Conversation
TST: fix the tests
30fef49
to0f77ba9
CompareThanks! |
Should the api change now be adapted as well? |
Hmmm, I don't think I put in an API change note for the original deprecation, which was an oversight. |
So now that I think about this a bit more, do wereally want to get rid of |
I'd definitively get rid of
|
OK, so left the pending deprecations in, but changed the deprecation note to say that set_tight/constrained_layout are discouraged rather than that they will be deprecated. |
PR Summary
Closes#22343
As noted there, deprecating immediately emits a DeprecationWarning, whereas this will emit a PendingDeprecationWarning.
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).