Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Rename outdated seaborn styles.#22317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jklymak merged 1 commit intomatplotlib:mainfromanntzer:snsty
Jan 26, 2022
Merged

Conversation

anntzer
Copy link
Contributor

@anntzeranntzer commentedJan 25, 2022•
edited
Loading

They are kept available under a versioned name for backcompat.

See#20252,#8351,#13680.

attn@mwaskom, I guess.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

Copy link
Member

@tacaswelltacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Modulo adding a test that this actually warns (just for 1 name).

They are kept available under a versioned name for backcompat.
@anntzer
Copy link
ContributorAuthor

test added.

@mwaskom
Copy link

LGTM, thanks@anntzer

@jklymakjklymak merged commit5743492 intomatplotlib:mainJan 26, 2022
@anntzeranntzer deleted the snsty branchJanuary 26, 2022 08:27
@timhoffm
Copy link
Member

timhoffm commentedJan 26, 2022•
edited
Loading

Just wondering, would the spellingseaborn-0.8-bright be better thanseaborn0.8-bright?

@tacaswell
Copy link
Member

I mildly prefer without the dash as the dash here is specifying something with in the namespace of seaborn styles and the 0.8 is clarifying that it is the namespace of a particular version of seaborn and we do not plan to pick up style sheets for every version of seaborn.

On the other hand,seaborn-0.8-bright does scan a bit better.

I also proposeseaborn08 with no extra punctuation.

@QuLogic
Copy link
Member

There is a vague convention in Fedora that compatibility packages be named<name><version> without other changes (and then subpackages would be<name><version>-<subpackage>), so I have a slight preference for that (i.e.,seaborn0.8-bright, etc.)

@timhoffm
Copy link
Member

The python packaging naming convention isseaborn-0.8.tar.gz (https://pypi.org/project/seaborn/#files).

@QuLogic
Copy link
Member

Those are notbackwards-compatibility names though; those are<name>-<version>, whereas I mean<name><oldversion> asthe name itself.

@timhoffm
Copy link
Member

I don't see (the point of) the distinction, but concerning package compatiblity I'm just a simple user 🤷.

bwfbowen added a commit to bwfbowen/bsuite that referenced this pull requestOct 30, 2023
Changes in matplotlib style name,matplotlib/matplotlib#22317
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

6 participants
@anntzer@mwaskom@timhoffm@tacaswell@QuLogic@jklymak
[8]ページ先頭
©2009-2025 Movatter.jp