Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
MNT: Deprecate cbook.maxdict#22299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
It was used in one place in the library and there is nowa standard library lru_cache that we can take advantage of instead.
| @functools.lru_cache(maxsize=50) | ||
| def _get_layout_cache(self, key, renderer): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is broken from what@anntzer mentioned, because it's caching onself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🐑 Doh! Should have read that closer. I'll move to draft for now and wait until#22271 goes in to have another look at this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
FYI#22271 is in.
Closing in favor of#22323 |
PR Summary
It was used in one place in the library and there is now a standard library lru_cache that we can take advantage of instead. This adds a new private method that is called after the key is created.
Closes#22278
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).