Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add minimum macosx version#22240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 2 commits intomatplotlib:mainfromdstansby:osx-version
Feb 17, 2022
Merged

Conversation

dstansby
Copy link
Member

@dstansbydstansby commentedJan 15, 2022•
edited
Loading

This is a draft to see if we can specify the macosx minimum version to be higher to fix wheel building. See#22179 (comment) for details on why the wheels are currently failing.

As per#18128 (comment) and other discussion on that issue I've set the minimum version to 10.12.

Fixes#18066

@dstansbydstansby added the CI: Run cibuildwheelRun wheel building tests on a PR labelJan 15, 2022
@dstansbydstansby marked this pull request as draftJanuary 15, 2022 15:54
@QuLogic
Copy link
Member

Probably should setthe deployment target in cibuildwheel.

dstansby reacted with thumbs up emoji

@dstansbydstansby added this to thev3.6.0 milestoneJan 20, 2022
@dstansbydstansby marked this pull request as ready for reviewJanuary 20, 2022 22:43
setupext.py Outdated
Comment on lines 734 to 735
ext.extra_compile_args.extend(['-Werror', '-mmacosx-version-min=10.12'])
ext.extra_link_args.extend(['-framework', 'Cocoa', '-mmacosx-version-min=10.12'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do we actually need this? I think the environment variableMACOSX_DEPLOYMENT_TARGET should be used instead, which you already have defined above. This says they are synonymous, and more importantly that this flag is actually a gcc flag that clang supports for now, but potentially not into the future.
https://stackoverflow.com/questions/25352389/what-is-the-difference-between-macosx-deployment-target-and-mmacosx-version-min

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've removed this change from my latest commit to see if it's needed.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It turns out we didn't need this - builds seem to be fine with just the environment variable set.

greglucas reacted with thumbs up emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@greglucasgreglucasgreglucas approved these changes

Assignees
No one assigned
Labels
BuildCI: Run cibuildwheelRun wheel building tests on a PROS: Apple
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

Document minimum supported OSX version for macos backend
3 participants
@dstansby@QuLogic@greglucas
[8]ページ先頭
©2009-2025 Movatter.jp