Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Run wheel builds on PRs when requested by a label#22235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dstansby merged 1 commit intomatplotlib:mainfromQuLogic:labeled-wheel
Jan 15, 2022

Conversation

QuLogic
Copy link
Member

@QuLogicQuLogic commentedJan 15, 2022•
edited
Loading

PR Summary

When I need to change the wheel building process, I need to push a copy to my fork'smain, and then force push that away. But we can enable this on PRs by checking for a special label, reducing this extra work.

I used the "Run cibuildwheel" label, but if there's consensus for a better label name, we can use it. Then I'll actually create the label.

PR Checklist

Tests and Styling

  • [n/a] Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

Copy link
Member

@jklymakjklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I wonder if we want a prefix for this that makes it clear its private?_run cibuildwheel?

@dstansbydstansby added the CI: Run cibuildwheelRun wheel building tests on a PR labelJan 15, 2022
@dstansby
Copy link
Member

I wonder if we want a prefix for this that makes it clear its private?_run cibuildwheel?

Only developers can add issues AFAIK, so I think this is fine? I added the label, and labelled this issue, just to double check it works. Looks like it does 👍 I'll merge without waiting for the wheel builds to finish, and feel free to change the colour of the label.

@dstansbydstansby merged commitea3b715 intomatplotlib:mainJan 15, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJan 15, 2022
@QuLogicQuLogic deleted the labeled-wheel branchJanuary 15, 2022 10:15
dstansby added a commit that referenced this pull requestJan 18, 2022
…235-on-v3.5.xBackport PR#22235 on branch v3.5.x (Run wheel builds on PRs when requested by a label)
@QuLogicQuLogic mentioned this pull requestFeb 2, 2022
1 task
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak left review comments

@tacaswelltacaswelltacaswell approved these changes

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Labels
BuildCI: Run cibuildwheelRun wheel building tests on a PRMaintenance
Projects
None yet
Milestone
v3.5.2
Development

Successfully merging this pull request may close these issues.

4 participants
@QuLogic@dstansby@tacaswell@jklymak
[8]ページ先頭
©2009-2025 Movatter.jp