Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Drop support for Python 3.7#22194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 4 commits intomatplotlib:mainfromQuLogic:no-py37
Feb 11, 2022
Merged

Conversation

QuLogic
Copy link
Member

@QuLogicQuLogic commentedJan 11, 2022
edited
Loading

PR Summary

According to NEP 29 [1], Python 3.7 support should be dropped after Dec 26, 2021. As Matplotlib 3.6 will be out a few months from now, it is already time to be dropping 3.7.

I added Python 3.10 runs in place of 3.7 where they didn't already exist.

[1]https://numpy.org/neps/nep-0029-deprecation_policy.html#support-table

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

@QuLogicQuLogic added Maintenance PR: dependenciesPull requests that update a dependency file labelsJan 11, 2022
@QuLogicQuLogic added this to thev3.6.0 milestoneJan 11, 2022
@QuLogic
Copy link
MemberAuthor

Ah, there's no NumPy wheel, we should probably bump that first.

@QuLogic
Copy link
MemberAuthor

NEP 29 says we should be on NumPy 1.19 already; we're still on 1.17. I hope the two release bump is okay?

tacaswell reacted with thumbs up emoji

@tacaswell
Copy link
Member

I think jumping 2 versions is OK. The mistake was not bumping earlier, no reason to compound that by not bumping far enough now.

timhoffm reacted with thumbs up emoji

@tacaswell
Copy link
Member

There are not wheels for pillow6.2.0 for py38 but there are for 6.2.1

@tacaswelltacaswell marked this pull request as ready for reviewJanuary 13, 2022 19:19
@QuLogicQuLogicforce-pushed theno-py37 branch 2 times, most recently frombd48c68 to4629c04CompareJanuary 14, 2022 01:14
@QuLogic
Copy link
MemberAuthor

I tried building witholdest-supported-numpy, but that installed an older version on Python 3.8, and thesetup_requires bumped it to the latest, which didn't have wheels, so I had to do a fixed version there.

Also, disabled PyPy temporarily as the version of cibuildwheel that supports it breaks Windows builds, which I need to investigate and report upstream.

But otherwise,the wheels are building.

@QuLogic
Copy link
MemberAuthor

And AppVeyor doesn't have a 3.9 miniconda, so I just went with the default one instead.

@tacaswell
Copy link
Member

Addingimage: "Visual Studio 2022" should switch us to a new image that has a py38 miniconda.

It also looks like they have a bunch of "system" python build (https://www.appveyor.com/docs/windows-images-software/#python) if we update the image. I am not sure if we want to keep appveyor on conda (so we can test that things work as exected in conda), move it to the system Python or just drop appveyor all together.

@QuLogic
Copy link
MemberAuthor

Addingimage: "Visual Studio 2022" should switch us to a new image that has a py38 miniconda.

Yes, but there's still no 3.9 one.

@QuLogic
Copy link
MemberAuthor

Not sure why Tk is missing on macOS for Python 3.10; is anyone running 3.10 on a mac that can check?

@greglucas
Copy link
Contributor

I have no issues with tk locally, from a fresh Python 3.10 installation from the release page.
image

I also don't have any issue with a conda python3.10 environment and running the interactive tests. It may be due to the MacOS 11 image...
https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=azure-devops&tabs=yaml

@tacaswell
Copy link
Member

I think the right fix here is to be more careful about assuming tk is available in the tests.

@QuLogic
Copy link
MemberAuthor

Seems to be a bug Azure environment:actions/runner-images#4931

@QuLogic
Copy link
MemberAuthor

QuLogic commentedFeb 2, 2022
edited
Loading

So here it's failing intest_backends_interactive because of missing TkAgg. There is a skip, but the problem is it just checks that the package exists, and doesn't attempt an import, probably to avoid conflicts. The failure here is that it cannot be imported, not that it doesn't exist.

I don't know if we want to try harder to skip these sorts of errors (Azureshould be deploying a fix this week some time), as it might require some extra communication from the subprocess to the main test. Maybe the changes in#22005 would make it easier?

@tacaswell
Copy link
Member

I think one of later commits in#22005 will correctly skip tk in this case (but it is failing on the py37 issues again).

@QuLogic
Copy link
MemberAuthor

It looks like the fixes were tagged yesterday, but just haven't been rolled out to all builders yet.

@QuLogic
Copy link
MemberAuthor

They needed another fix; rollout is this week some time (I guess starting on the 9th probably.)

QuLogicand others added4 commitsFebruary 10, 2022 22:06
According to NEP 29 [1], Python 3.7 support should be dropped afterDec 26, 2021. As Matplotlib 3.6 will be out a few months from now, it isalready time to be dropping 3.7.[1]https://numpy.org/neps/nep-0029-deprecation_policy.html#support-table
This is supported by the latest cibuildwheel, but using that breaksWindows builds, so I'll look into that separately.
We need wheels to get webp support (which we test).
@QuLogic
Copy link
MemberAuthor

Deployment is around 99.9%, but it's close enough to get our build working. By the time this is merged, their fix will probably be out on all Azure machines.

@greglucas
Copy link
Contributor

Looks like the upstream got resolved. I'll hold off on merging in case you were waiting on any other runners/updates. Feel free to self-merge.

@tacaswelltacaswell merged commitac3d0ca intomatplotlib:mainFeb 11, 2022
@QuLogicQuLogic deleted the no-py37 branchFebruary 11, 2022 21:34
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@greglucasgreglucasgreglucas approved these changes

Assignees
No one assigned
Labels
MaintenancePR: dependenciesPull requests that update a dependency file
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@tacaswell@greglucas

[8]ページ先頭

©2009-2025 Movatter.jp