Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Deprecatedafm
,fontconfig_pattern
, andtype1font
#22133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
392b49d
to7ed5b69
Comparetype1font
afm
,fontconfig_pattern
, andtype1font
oscargus commentedJan 6, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
How should one deal with these issues:
Should one change the previous links to point to the new one? Reformat them to not be a link? Import the required classes/functions explicitly in the to-be-removed file? Especially: there is a PR#20715 that changes the now deprecated methods/classes. Should this be dealt with in a special way? Since it is now deprecated/private. |
7ed5b69
to045121b
Comparetimhoffm commentedJan 6, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Please change the links in API changes to code literals using fully qualified names, e.g.
to
The API changes are historic documents for that point in time and we should not change their meaning. We can't reference with links in the current docs so the best option is literals. This is also true for the unreleased Concerning the first one, change |
It is only used (in the matplotlib codebase) in For consistency, one may also consider making |
08c4ed7
tofd6b5b9
Compare
timhoffm left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please switch to the two-commit solution as described in#22134 (review) to preserve history here as well.
fd6b5b9
to406cd41
Compare406cd41
to1885e46
CompareImports are slightly improved here as well. |
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
Related to#16181.
Will update with release notes once the tests pass (and I get a PR-number...)
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).