Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

TST: Increase fp tolerances for some images#22132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 3 commits intomatplotlib:mainfromgreglucas:tst-fp-tolerances
Jan 6, 2022

Conversation

greglucas
Copy link
Contributor

PR Summary

This reverts PR#22099 and instead bumps the tolerances of some of the image tests. This is due to the AVX512 instruction set being used on some CI runners.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

Copy link
Member

@jklymakjklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I prefer this to a bunch of compiler flags. But I'm not expert on what is "correct"

This is for floating point errors that crept in withAVX512 instruction sets on some CI architectures.
Copy link
Member

@tacaswelltacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Anyone can merge on CI green.

@tacaswelltacaswell added this to thev3.5.2 milestoneJan 6, 2022
@QuLogicQuLogic merged commit3d91b3f intomatplotlib:mainJan 6, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJan 6, 2022
QuLogic added a commit that referenced this pull requestJan 7, 2022
…132-on-v3.5.xBackport PR#22132 on branch v3.5.x (TST: Increase fp tolerances for some images)
@greglucasgreglucas deleted the tst-fp-tolerances branchJanuary 7, 2022 14:51
jklymak pushed a commit that referenced this pull requestOct 25, 2022
This is similar to#22132 in that NumPy has added more code paths thatnow take advantage of AVX512 optimizations and causes slight variationsin results.Fixes#24060
melissawm pushed a commit to melissawm/matplotlib that referenced this pull requestDec 19, 2022
This is similar tomatplotlib#22132 in that NumPy has added more code paths thatnow take advantage of AVX512 optimizations and causes slight variationsin results.Fixesmatplotlib#24060
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.2
Development

Successfully merging this pull request may close these issues.

4 participants
@greglucas@tacaswell@jklymak@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp