Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

color of candlestick lines#2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:masterfromprofholzer:patch-1
Jan 13, 2014
Merged

Conversation

profholzer
Copy link
Contributor

the line of a candlestick should have the same color as the body (rectangle)

the line of a candlestick should have the same color as the body (rectangle)
@profholzer
Copy link
ContributorAuthor

Usually the upper and lower shadow have the same color as the body. The other option is to draw the body first to avoid the ugly black line through it.
But: If the background is black, the shadows will vanish.

@tacaswell
Copy link
Member

If you are going to do work on thefinance.py could you do it againsthttps://github.com/tacaswell/matplotlib/tree/ochl_to_ohlc (see PR#1920 ) to make the eventual merge easier?

If you actuallyusefinance do you want to take over herding#1920 through merging?

@mdboom
Copy link
Member

@profholzer: Just so we don't lose track of this... Did you close because this is the wrong approach, or because you, following@tacaswell's suggestion, made this against his branch? If the latter, we should reference which PR that work moved to.

@profholzer
Copy link
ContributorAuthor

Hi,
this was my first attempt to give something back to the matplotlib developers and I simply don't know, what I should do exactly, because I am not familiar to the methods of reporting bugs or enhancements.
Sorry for my inactivity due to the wrong approach. I saw that other users made the same recommendation earlier.

Regards
Alexander

Am 16.07.2013 um 18:43 schrieb Michael Droettboomnotifications@github.com:

@profholzer: Just so we don't lose track of this... Did you close because this is the wrong approach, or because you, following@tacaswell's suggestion, made this against his branch? If the latter, we should reference which PR that work moved to.


Reply to this email directly or view it on GitHub.

@mdboom
Copy link
Member

Ok -- why don't we do this, then. I'll reopen the bug, and once#1902 is merged, we can reassess where we are wrt this issue.

@mdboommdboom reopened thisJul 16, 2013
@tacaswell
Copy link
Member

@mdboom There is a typo in your comment, it is#1920 not 1902

tacaswell added a commit that referenced this pull requestJan 13, 2014
@tacaswelltacaswell merged commit2b9fced intomatplotlib:masterJan 13, 2014
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

3 participants
@profholzer@tacaswell@mdboom

[8]ページ先頭

©2009-2025 Movatter.jp