Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

MNT: Set CapStyle member names automatically#22054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromStefRe:mnt/_enums
Jan 2, 2022

Conversation

StefRe
Copy link
Contributor

PR Summary

This was certainly overlooked in#18544, otherwise it would make no sense to deriveCapStyle from_AutoStringNameEnum.

PR Checklist

Tests and Styling

  • [N/A] Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

This was certainly overlooked inmatplotlib#18544, otherwise it would makeno sense to derive CapStyle from _AutoStringNameEnum.
@StefRe
Copy link
ContributorAuthor

Github seems to have aproblem with setting up reviewdog. What should I do in such a case - just force push once more?

@dstansbydstansby added this to thev3.6.0 milestoneDec 31, 2021
@dstansby
Copy link
Member

Is this technically an API change if users are accessing and using these attributes? Can we set them to enums with their previous string values so it's less API breaking?

@StefRe
Copy link
ContributorAuthor

Is this technically an API change?

No, absolutely nothing changes - usingxyz = auto() with the provided_AutoStringNameEnum class is just a somewhat more convoluted way of writingxyz = 'xyz' to avoid the repetition (was introduced ind2de8a2).

@timhoffmtimhoffm merged commit0c1aa86 intomatplotlib:mainJan 2, 2022
@StefReStefRe deleted the mnt/_enums branchJanuary 2, 2022 20:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

@brunobeltranbrunobeltranAwaiting requested review from brunobeltran

Assignees
No one assigned
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

4 participants
@StefRe@dstansby@anntzer@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp