Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DOC: Document default cap styles#22053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromStefRe:fix/issue21979
Jan 11, 2022

Conversation

StefRe
Copy link
Contributor

PR Summary

  • remove '(default)' from cap style demo as this is only true for Line2D
    and the default rcParameters
  • document default cap styles for Line2D and Patch in their cap style
    setters
  • document default cap style for GraphicsContextBase in the same way as
    it's already done for joinstyle

Closes#21979. If this goes in I can do the same for join styles, see#18597 (just documenting the current state).

PR Checklist

Tests and Styling

  • [N/A] Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

@StefRe
Copy link
ContributorAuthor

Hm, I don't quite understand why test coverage failed (coverage decreased by 0.06 %) when I deleteone line of code
in a function that is not covered by any tests. Coverage shouldincrease in such a case, shouldn't it?

@StefRe
Copy link
ContributorAuthor

Hm, CircleCIfailed with

fatal: remote error:
The unauthenticated git protocol on port 9418 is no longer supported.
Please seehttps://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.

I guess this is unrelated to the PR.

@StefReStefRe requested a review fromtimhoffmJanuary 11, 2022 10:40
@timhoffm
Copy link
Member

The error is fixed in#22190. Please rebase on main so that we are sure there are no other issues in the doc build.

- remove '(default)' from cap style demo as this is only true for Line2D  and the default rcParameters- document default cap styles for Line2D and Patch in their cap style  setters- document default cap style for GraphicsContextBase in the same way as  it's already done for joinstyle
@StefRe
Copy link
ContributorAuthor

The error is fixed in#22190. Please rebase on main so that we are sure there are no other issues in the doc build.

Sorry, didn't see that. Rebased and completed the suggested changes.

@StefReStefRe requested a review fromtimhoffmJanuary 11, 2022 15:44
@timhoffmtimhoffm added this to thev3.5.2 milestoneJan 11, 2022
@timhoffmtimhoffm merged commiteaadeb6 intomatplotlib:mainJan 11, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJan 11, 2022
@StefReStefRe deleted the fix/issue21979 branchJanuary 11, 2022 18:58
timhoffm added a commit that referenced this pull requestJan 11, 2022
…053-on-v3.5.xBackport PR#22053 on branch v3.5.x (DOC: Document default cap styles)
@StefReStefRe mentioned this pull requestJan 12, 2022
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.5.2
Development

Successfully merging this pull request may close these issues.

[Doc]: Clarify default capstyle
2 participants
@StefRe@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp