Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Deprecate various custom FigureFrameWx attributes/methods.#22025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seems like this might conflict with a few of the others.
It's OK, as usual I'll rebase in whatever order necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good, but needs a rebase.
rebased. |
I notified you too soon. Needs another one after the last merge. |
They all have simple aliases under more standard names.... and while we're at it, also deprecate the never-ever-usedRendererWx.offset_text_height, and switch the RendererWx deprecation touse a standard decorator.
done. |
Uh oh!
There was an error while loading.Please reload this page.
They all have simple aliases under more standard names.
... and while we're at it, also deprecate the never-ever-used
RendererWx.offset_text_height, and switch the RendererWx deprecation to
use a standard decorator.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).