Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Use standard toolbar in wx.#22013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Makes sense conceptually, but I have not tested it.
The previous approach manually positioned the toolbar to have it at thebottom of the window, but this can in fact be achieved just withstyle=wx.TB_BOTTOM.Removing manual sizing of the toolbar also fixes a bug previouslypresent on Windows, whereby a `set_size_inches` reducing the size of thecanvas would *not* reduce the window width, likely because it was forcedto its max value by the toolbar's explicit size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks and behaves well.
The previous approach manually positioned the toolbar to have it at the
bottom of the window, but this can in fact be achieved just with
style=wx.TB_BOTTOM.
Removing manual sizing of the toolbar also fixes a bug previously
present on Windows, whereby a
set_size_inchesreducing the size of thecanvas wouldnot reduce the window width, likely because it was forced
to its max value by the toolbar's explicit size.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).