Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Autoinfer norm bounds.#21989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:mainfromanntzer:autonormbounds
Dec 17, 2021
Merged

Conversation

anntzer
Copy link
Contributor

Instead of special-casing lognorm to only autoscale from positive
values, perform autoscaling from values that map to finite transformed
values. This ensures e.g. that make_norm_from_scale(LogitScale)
automatically does the right thing (autoscaling from values in [0, 1]).

This means that autoscale() and autoscale_None() are now slightly more
expensive (because the transform needs to be applied), so skip the call
to autoscale_None if not needed. However, note that these should
typically only be called once per norm anyways, so hopefully this isn't
a bottleneck.

(Another idea would be to usetrf.inverse().transform([-np.inf, np.inf])
as clipping bounds, but there are some tests usingx->x**2
/x->sqrt(x) as a test for FuncNorm, which 1. doesn't go all the way
to -inf, and 2. isn't even increasing for negative x's, so that idea
doesn't work.)

(See the first remaining issue of#20752, which is the motivation for this.)

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

Instead of special-casing lognorm to only autoscale from positivevalues, perform autoscaling from values that map to finite transformedvalues.  This ensures e.g. that make_norm_from_scale(LogitScale)automatically does the right thing (autoscaling from values in [0, 1]).This means that autoscale() and autoscale_None() are now slightly moreexpensive (because the transform needs to be applied), so skip the callto autoscale_None if not needed.  However, note that these shouldtypically only be called once per norm anyways, so hopefully this isn'ta bottleneck.(Another idea would be to use `trf.inverse().transform([-np.inf,np.inf])` as clipping bounds, but there are some tests using `x->x**2`/ `x->sqrt(x)` as a test for FuncNorm, which 1. doesn't go all the wayto -inf, and 2. isn't even increasing for negative x's, so that ideadoesn't work.)
Copy link
Member

@tacaswelltacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is clever.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

3 participants
@anntzer@tacaswell@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp