Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

DOC: remove experimental tag from CL#21975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jklymak merged 1 commit intomatplotlib:mainfromjklymak:doc-CL-not-expertimental
Dec 17, 2021

Conversation

jklymak
Copy link
Member

PR Summary

Constrained layout is not really experimental any more, and we probably should not break it at this point....

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

@jklymak
Copy link
MemberAuthor

Note I also adjusted theFigure layout docstring. I think both layout managers suffer performance constraints, just the worse ones for constrained_layout you simply wouldn't even expect anything sensible from tight_layout.

@jklymakjklymakforce-pushed thedoc-CL-not-expertimental branch frombd740ce to3a4c0fbCompareDecember 16, 2021 12:36
@dstansbydstansby added this to thev3.6.0 milestoneDec 16, 2021
Copy link
Member

@dstansbydstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

With an optional suggestion

Comment on lines 2218 to 2219
layout managers can have significant performance penalties as
they require an extra draw and solve an inverse problem.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
layoutmanagerscanhavesignificantperformancepenaltiesas
theyrequireanextradrawandsolveaninverseproblem.
layoutmanagerscanhavesignificantperformancepenalties.

For brevity, I don't think we need to explain why?

timhoffm reacted with thumbs up emoji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm weakly in favor of brevity here as well.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done...

Copy link
Member

@tacaswelltacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Same as@dstansby

@jklymak can self-merge with or without the wording change.

@jklymakjklymakforce-pushed thedoc-CL-not-expertimental branch from3a4c0fb to8cbe67eCompareDecember 17, 2021 07:50
@jklymakjklymak merged commite3555f5 intomatplotlib:mainDec 17, 2021
@jklymakjklymak deleted the doc-CL-not-expertimental branchDecember 17, 2021 08:45
@QuLogicQuLogic mentioned this pull requestSep 9, 2022
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

3 participants
@jklymak@tacaswell@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp