Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Jointly track x and y in PolygonSelector.#21894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromanntzer:polygonselectorxy
Jan 12, 2022

Conversation

anntzer
Copy link
Contributor

It's easier to track them in a single list.

Also init _selection_artist and _polygon_handles with empty arrays, as
there's no reason to pretend that they start with 0, 0. On the other
hand, _xys does need to start as a non-empty array as the last point
gets updated as being the cursor position.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

@dstansby
Copy link
Member

Can we wait until#21830 is merged for this to go in?

@anntzer
Copy link
ContributorAuthor

Sure, sorry, I had only noticed#21881 as potentially conficting.

@ericpre
Copy link
Member

#21830 has been merged,@anntzer, can you please rebase this PR?

@anntzer
Copy link
ContributorAuthor

Thanks for the notification, rebased.

@anntzeranntzer marked this pull request as ready for reviewJanuary 9, 2022 17:21
@QuLogic
Copy link
Member

Seems to have broken some things.

@anntzer
Copy link
ContributorAuthor

Thanks, I missed a point when rebasing over#21830.

Copy link
Member

@dstansbydstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Much nicer, thanks a lot! This approval is contingent on CI passing.

It's easier to track them in a single list.Also init _selection_artist and _polygon_handles with empty arrays, asthere's no reason to pretend that they start with 0, 0.  On the otherhand, _xys does need to start as a non-empty array as the last pointgets updated as being the cursor position.
@timhoffmtimhoffm added this to thev3.6.0 milestoneJan 12, 2022
@timhoffmtimhoffm merged commit51f10e2 intomatplotlib:mainJan 12, 2022
@anntzeranntzer deleted the polygonselectorxy branchJanuary 12, 2022 19:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

5 participants
@anntzer@dstansby@ericpre@QuLogic@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp