Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix rotation selector for aspect ratio of the axes values different from 1#21886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
This does fix the slow rotation issue for me, but only partially. I can't seem to rotate the selector past +-45 degrees however. |
The limitation to +-45 degrees rotation is expected to avoid issues with the handle assignment. |
dhomeier commentedDec 13, 2021
Fixes the angle synchronisation for me as well.
Do you recall what specifically happens, or how to reproduce those issues? I could not notice much when removing the 45˚ limit; only when approaching 180˚ the rotation seems to become discontinuous. |
Sorry, I don't know more what I already mentioned in#20839 (comment). |
dhomeier commentedDec 13, 2021
I can confirm your expectation on the defonselect(epress,erelease=None):print(tool._active_handle,tool.rotation) a given corner handle keeps its label through any number of rotations, whereas e.g. inverting the rectangle – click the |
@dhomeier, is it worth discussing this in a dedicated issue or PR? If not, the discussion will get lost as this PR is not about increasing the rotation limits. |
dhomeier commentedDec 13, 2021
Yes, lets move to another issue - I'll open one. |
I now have a working version of |
Yes, makes sense, I am happy to give an early review, even if this is not finish yet! :) |
I guess I'm not sure about merging this? Feel free to do so if you think it doesn't need a Whats new entry, and it is consistent with the current state of the docs... |
Pushing to 3.8 as the last comment suggests waiting for#21945 |
PR Summary
Rotate counterclockwise to notice that the selector rotate too slowly because of the aspect ratio value difference
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).