xref#21819

I am still a bit concerned about this,wheel is only actually needed to build wheels (as opposed to installing).

python -m pip install 'git+https://github.com/matplotlib/matplotlib.git#egg=matplotlib'

works for me without wheel installed, even if it includes the ominous message

Using legacy 'setup.py install' for matplotlib, since package 'wheel' is not installed.

. If I installwheel in the environment that I run

python -m pip wheel 'git+https://github.com/matplotlib/matplotlib.git#egg=matplotlib'

from it works and if I removewheel from that environment I get the error@franzhaas reports. I would have expected thatpip would have complained about the lack ofwheel when it is asked to build a wheel rather than waiting from a package to actually use it. I suspect that this is some oddness coming from the migration to using build isolation andpyproject.toml (which we have not adopted yet).

@franzhaas Why are you trying to build the wheel like this?

Looking through our CI, it looks like we explicitly installwheel in circle, build the wheel on appveyor (did not track down if we install it or if the conda env just has it), and we explicitly installwheel on GHA.

This leads to conclude that while we do not strictly need to depend on wheel as a build-time dependency, in 3/4 of our CI systems we have installed it anyway, there is no harm in adding it as a build-time dependency (and we fix@franzhaas 's use case to boot).

Can you also add a line tohttps://github.com/matplotlib/matplotlib/blob/cced93b1ee29e0653f70e96ffb90ec2cc1341c8d/doc/devel/dependencies.rst (which notable we missed doing when we added setuptool-scm, that is our mistake 🐑 )

I agree that wheel is not necessary as part ofsetup_requires.

@franzhaas Why are you trying to build the wheel like this?

This is because for my environment i build a bunch of wheels from source. (although normaly i take the wheel of matplotlib from pypi)

Having a standard python installed and run this one line for every wheel i intend to use is convinient.

Once I start preparing the build environment it gets involved. I have to document how to do it, where to place them, and what is in it, and that propably ends up varying over time, and over wheels.

So buttom line.:
It is convinient for the situation I am in, due to choices i made in the past. I could have gone a diferent way, or change now, that would be inconvinient, but definitely possible.

Thanks a lot,
Franz

Well I'd saywheel is your dependency for the environment and what you want to accomplish, not a dependency for anything related to the build of matplotlib.

You should probably stop usingsetup_requires completely (it's quite bad practice, invokeseasy_install becausepip doesn't know how to handle it) and add apyproject.toml file - includingwheel there. And insetup.py just raise an exception when a build-time dependency is missing.

I believe this PR is not going anywhere. It only affects a specific way to build wheels, which is very niche, there are alternatives available and documented.

The current situation is plenty good enough, the proposed improvement is minor or maybe even disputed, i close this PR.

Thank you for being understanding@franzhaas .

I do see where you are coming from here, but agree with@dopplershift that if you know you want wheels, making sure your standard Python environment has and up-to-date pip + wheel installed is reasonable expectation.

Hopefully we will hear from you again!