This allows one to put a bounding box around a PolygonSelector, that can be used for resizing and moving (and eventually rotating) the selector points.

importmatplotlib.pyplotaspltfrommatplotlib.widgetsimportPolygonSelectorfig,ax=plt.subplots()sel=PolygonSelector(ax,lambda*args,**kwargs:None,draw_box=True)plt.show()

polygon.mov

PR Checklist

Tests and Styling

Has pytest style unit tests (andpytest passes).
IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

New features are documented, with examples if plot related.
New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

dstansby added the topic: widgets/UI label

Dec 1, 2021

dstansby force-pushed thepolygon-box branch 2 times, most recently from5847eda to4ac8e37Compare

December 3, 2021 11:06

dstansby added this to thev3.6.0 milestone

Dec 3, 2021

Copy link

MemberAuthor

dstansby commentedDec 3, 2021

This should be ready for review now

ericpre reviewed

Dec 5, 2021

View reviewed changes

Copy link

Member

ericpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This works nicely, I made a couple of comments/suggestions.

lib/matplotlib/widgets.py OutdatedShow resolvedHide resolved

lib/matplotlib/widgets.pyShow resolvedHide resolved

lib/matplotlib/widgets.py OutdatedShow resolvedHide resolved

dstansby force-pushed thepolygon-box branch from955354d tofbe3273Compare

December 5, 2021 17:56

dhomeier mentioned this pull request

Dec 8, 2021

Add interactive matplotlib selector toPolygonPixelRegionastropy/regions#406

Draft

dhomeier suggested changes

Dec 8, 2021

View reviewed changes

Copy link

dhomeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR and updates; I have tested this with a method inastropy/regions#406 that uses this new functionality and see that some early quirks have already been resolved!
A general issue with thatregions method, which connects a customPolygonSelector, is that creating a complete instance is somewhat tedious – adding the vertices and then triggering a redraw and finally marking the selector_selection_completed; for most of this I have not found public methods for the required operations. Having those, analogously toextents etc. inRectangleSelector would be a plus (but not necessary from this PR).

lib/matplotlib/widgets.pyShow resolvedHide resolved

dstansby mentioned this pull request

Dec 9, 2021

Jointly track x and y in PolygonSelector.#21894

Merged

6 tasks

dstansby force-pushed thepolygon-box branch from1095445 to0f8d264Compare

December 9, 2021 21:38

dstansby marked this pull request as ready for review

December 9, 2021 21:43

ericpre approved these changes

Dec 11, 2021

View reviewed changes

Copy link

Member

ericpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks good, it just need the test to be fixed!

lib/matplotlib/tests/test_widgets.py OutdatedShow resolvedHide resolved

dstansby force-pushed thepolygon-box branch fromca3c9c6 toa2d4414Compare

December 13, 2021 17:41

dstansby added the status: needs review label

Dec 16, 2021

QuLogic reviewed

Dec 22, 2021

View reviewed changes

Copy link

Member

QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I wonder if it should be calleddraw_bbox, or evendraw_bounding_box (since we seem to have pretty verbose names in widgets already.)

lib/matplotlib/tests/test_widgets.py OutdatedShow resolvedHide resolved

lib/matplotlib/tests/test_widgets.py

Comment on lines +1484 to +1409

		event_sequence = (polygon_place_vertex(*verts[0]) +
		polygon_place_vertex(*verts[1]) +
		polygon_place_vertex(*verts[2]) +
		polygon_place_vertex(*verts[3]) +
		polygon_place_vertex(*verts[0]))

Copy link

Member

QuLogicDec 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	event_sequence= (polygon_place_vertex(*verts[0])+
	polygon_place_vertex(*verts[1])+
	polygon_place_vertex(*verts[2])+
	polygon_place_vertex(*verts[3])+
	polygon_place_vertex(*verts[0]))
	event_sequence= (
	polygon_place_vertex(verts[0]),
	polygon_place_vertex(verts[1]),
	polygon_place_vertex(verts[2]),
	polygon_place_vertex(verts[3]),
	polygon_place_vertex(verts[0]),
	)

Copy link

MemberAuthor

dstansbyDec 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I didn't do this since the rest oftest_widgets.py uses the+ notation. I'd be happy to put in a PR to change it all in one go though?

lib/matplotlib/widgets.py OutdatedShow resolvedHide resolved

doc/users/next_whats_new/polygon_selector_box.rst OutdatedShow resolvedHide resolved

lib/matplotlib/tests/test_widgets.py OutdatedShow resolvedHide resolved

lib/matplotlib/widgets.py OutdatedShow resolvedHide resolved

dstansby added4 commits

December 23, 2021 11:48

Add option of bounding box for PolygonSelector

707844b

Update polygon every time bounding box is movedAllow box customisationRemove delPrevent rotation on polygon bounding boxFix line lengthCleanup transform logicDon't use dicts as keyword defaultsMinor doc fixes

Run exising polygon selector tests with draw_box=True

f228e2b

Run exising polygon selector tests with draw_box=True

Add tests for polygon selector box

a45ef42

Trigger events on canvas in testTest doc fixes

draw_box > draw_bounding_box

72e95f0

dstansby force-pushed thepolygon-box branch froma2d4414 to72e95f0Compare

December 23, 2021 11:49

Copy link

MemberAuthor

dstansby commentedDec 23, 2021

Thanks for reviewing. I changed the argument name todraw_bounding_box, but left the internal variables as_draw_box for simplicity. All other comments should be addressed. I also cleaned up the commit history a bit - sorry if this makes it a bit trickier to re-review...

QuLogic reviewed

Dec 24, 2021

View reviewed changes

doc/users/next_whats_new/polygon_selector_box.rst OutdatedShow resolvedHide resolved

Fix changelog argument name

60b28ab

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>

QuLogic reviewed

Dec 24, 2021

View reviewed changes

examples/widgets/polygon_selector_demo.py OutdatedShow resolvedHide resolved

Fix example

ba7fdf2

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>

QuLogic approved these changes

Jan 5, 2022

View reviewed changes

QuLogic merged commit37c9b04 intomatplotlib:main

Jan 5, 2022

QuLogic removed the status: needs review label

Jan 5, 2022

dstansby deleted the polygon-box branch

January 5, 2022 22:34

dstansby mentioned this pull request

Jan 8, 2022

Polygon rotation#22159

Draft

6 tasks

Labels

topic: widgets/UI

4 participants

Movatterモバイル変換

Uh oh!

Add option of bounding box for PolygonSelector#21830

Add option of bounding box for PolygonSelector#21830

Uh oh!

Conversation

dstansby commentedDec 1, 2021• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

dstansby commentedDec 3, 2021

Uh oh!

ericpre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dhomeier left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ericpre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

QuLogic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

QuLogicDec 22, 2021

Choose a reason for hiding this comment

Uh oh!

dstansbyDec 23, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dstansby commentedDec 23, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dstansby commentedDec 1, 2021•
edited
Loading