Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Revert backport of #21631 to v3.5.0-doc#21824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:v3.5.0-docfromQuLogic:v3.5.0-doc
Dec 3, 2021

Conversation

QuLogic
Copy link
Member

PR Summary

This PR renames a tutorial, and thus needs to update a link in a.py file. Changes to.py files have no effect on the -doc branch, because it is run against the released version, so this breaks the build since the old link is gone.

This reverts commit37131e9.

PR Checklist

Tests and Styling

  • [n/a] Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

@QuLogicQuLogic added this to thev3.5-doc milestoneDec 1, 2021
@QuLogic
Copy link
MemberAuthor

The Basic usage guide backport also appears to have broken things. I have half a mind to force-push these backports away, since this isn'tmain.

@jklymak
Copy link
Member

Oh, thats confusing. Sorry for the breakage, and of course feel free to revert what is needed.

@jklymak
Copy link
Member

... that is even more confusing, as the back ports passed CI - I guess its not worth having a different CI for these branches, but...

@tacaswell
Copy link
Member

We do not run the link-checker as part of CI and the CI does not try to install the released version.

Given that we now have a handful of git-related checks on GHA, I suspect would could set up a check that asserts nothing in the lib or src directories are changed on*-doc branches.

@tacaswell
Copy link
Member

I'm mixed on force-pushing to-doc. On one hand I'm against doing it as a bit of a social / process control thing. "do not force push to the matplotlib/matplotlib repo" is a very easy rule to understand and enforce. But we have broken 2x in the last 5 years (once "for real" and once kinda-sorta-language-lawyer-maybe-not) so it is actually "do not force push to the matplotlib/matplotlib repo except in extenuating circumstances" which is fuzzier. Doing it here would be another step down the path to normalizing force-pushing to matplotlib/matplotlib (slippery slope etc etc) so we should not.

On the other hand, there is no reason to keep commits + their reversions around, this is notmain and I strongly suspect that@QuLogic is the only person in the world that currently has it as a local branch so just do the simple thing and move on.

I'm pretty 50/50 on this and am OK with either option.

@QuLogic
Copy link
MemberAuthor

Fixing the usage guide is less work than I thought (only one line), but now I see other stuff was merged, so I'll need to check that that is okay.

@jklymak
Copy link
Member

I think there was only#21813 and#21815...

This PR renames a tutorial, and thus needs to updtae a link in a .pyfile. Changes to .py files have no effect on the -doc branch, because itis run against the released version, so this breaks the build since theold link is gone.This reverts commit37131e9.
@QuLogicQuLogic merged commitdb35fd7 intomatplotlib:v3.5.0-docDec 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5-doc
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@jklymak@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp