Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FIX: Make sure a renderer gets attached to figure after draw#21758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dstansby merged 1 commit intomatplotlib:mainfromgreglucas:macosx-fig-draw
Nov 28, 2021

Conversation

greglucas
Copy link
Contributor

@greglucasgreglucas commentedNov 26, 2021•
edited
Loading

PR Summary

Make sure that a cached renderer gets added to the figure after calling fig.canvas.draw() on the macosx backend. This changes the draw path to go through adding a renderer to the figure first.

closes#19197
closes#13968
closes#7550

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

Make sure that a cached renderer gets added to the figure aftercalling fig.canvas.draw()
@tacaswelltacaswell added this to thev3.5.1 milestoneNov 26, 2021
@tacaswell
Copy link
Member

This is legacy from when the OSX backend was not Agg based, but was implemented on top of the OSX native drawing API. In that API we could only get a graphics context inside of the UI draw loop, hence wehad to usedraw_idle and force the UI event loop to spin. Now that the OSX backend is Agg based, we do not have this restriction and can make OSX behave more in line with the other Agg-based GUI backends.

@dstansbydstansby merged commit171e74a intomatplotlib:mainNov 28, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestNov 28, 2021
@greglucasgreglucas deleted the macosx-fig-draw branchNovember 28, 2021 14:57
dstansby added a commit that referenced this pull requestNov 28, 2021
…758-on-v3.5.xBackport PR#21758 on branch v3.5.x (FIX: Make sure a renderer gets attached to figure after draw)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.1
3 participants
@greglucas@tacaswell@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp