Looks great to me. Any chance you could remove_text=True this to reduce the chance of it failing with different freetype versions? I'm also interested to know if your change means you can add color to the table - might be nice to update the test to include that (rather than creating a new test for that facet).

Nice work!

Do you mean add remove_text=True to @image_comparision? (added to PR).

You can use celColours keyword on axes.table() to set the cell (ie
Rectangle.facecolor) color. You can also specify color arguments to the
Table.add_cell() function. Is that sufficient or are you looking for
something else?

-matt

On Sat, Jun 29, 2013 at 2:35 PM, Phil Elsonnotifications@github.comwrote:

In lib/matplotlib/tests/test_table.py:

@@ -0,0 +1,37 @@
+import matplotlib.pyplot as plt
+import numpy as np
+from matplotlib.testing.decorators import image_comparison
+
+
+@image_comparison(baseline_images=['table_zorder'], extensions=['png'])

Looks great to me. Any chance you could remove_text=True this to reduce
the chance of it failing with different freetype versions? I'm also
interested to know if your change means you can add color to the table -
might be nice to update the test to include that (rather than creating a
new test for that facet).

Nice work!

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2167/files#r4952800
.

British spelling of color alert!
On Jun 29, 2013 3:27 PM, "Matt Terry"notifications@github.com wrote:

In lib/matplotlib/tests/test_table.py:

@@ -0,0 +1,37 @@
+import matplotlib.pyplot as plt
+import numpy as np
+from matplotlib.testing.decorators import image_comparison
+
+
+@image_comparison(baseline_images=['table_zorder'], extensions=['png'])

Do you mean add remove_text=True to @image_comparision? (added to PR). You
can use celColours keyword on axes.table() to set the cell (ie
Rectangle.facecolor) color. You can also specify color arguments to the
Table.add_cell() function. Is that sufficient or are you looking for
something else?
… <#13f919ed4d5ac63c_>
-matt
On Sat, Jun 29, 2013 at 2:35 PM, Phil Elsonnotifications@github.comwrote:
In lib/matplotlib/tests/test_table.py: > @@ -0,0 +1,37 @@ > +import
matplotlib.pyplot as plt > +import numpy as np > +from
matplotlib.testing.decorators import image_comparison > + > + >
+@image_comparison(baseline_images=['table_zorder'], extensions=['png'])
Looks great to me. Any chance you could remove_text=True this to reduce the
chance of it failing with different freetype versions? I'm also interested
to know if your change means you can add color to the table - might be nice
to update the test to include that (rather than creating a new test for
that facet). Nice work! — Reply to this email directly or view it on GitHub<
https://github.com/matplotlib/matplotlib/pull/2167/files#r4952800> .

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2167/files#r4952860
.

Is that something that should be exorcized?
On Jun 29, 2013 4:05 PM, "Benjamin Root"notifications@github.com wrote:

In lib/matplotlib/tests/test_table.py:

@@ -0,0 +1,37 @@
+import matplotlib.pyplot as plt
+import numpy as np
+from matplotlib.testing.decorators import image_comparison
+
+
+@image_comparison(baseline_images=['table_zorder'], extensions=['png'])

British spelling of color alert!
… <#13f91c117ea986fd_>
On Jun 29, 2013 3:27 PM, "Matt Terry"notifications@github.com wrote: >
In lib/matplotlib/tests/test_table.py: > > > @@ -0,0 +1,37 @@ > > +import
matplotlib.pyplot as plt > > +import numpy as np > > +from
matplotlib.testing.decorators import image_comparison > > + > > + > >
+@image_comparison(baseline_images=['table_zorder'], extensions=['png']) >

Do you mean add remove_text=True to @image_comparision? (added to PR).
You > can use celColours keyword on axes.table() to set the cell (ie >
Rectangle.facecolor) color. You can also specify color arguments to the >
Table.add_cell() function. Is that sufficient or are you looking for >
something else? > … <#13f919ed4d5ac63c_> > -matt > On Sat, Jun 29, 2013 at
2:35 PM, Phil Elsonnotifications@github.comwrote: In
lib/matplotlib/tests/test_table.py: > @@ -0,0 +1,37 @@ > +import
matplotlib.pyplot as plt > +import numpy as np > +from
matplotlib.testing.decorators import image_comparison > + > + >
+@image_comparison(baseline_images=['table_zorder'], extensions=['png'])
Looks great to me. Any chance you could remove_text=True this to reduce the
chance of it failing with different freetype versions? I'm also interested
to know if your change means you can add color to the table - might be nice
to update the test to include that (rather than creating a new test for
that facet). Nice work! — Reply to this email directly or view it on
GitHub<https://github.com/matplotlib/matplotlib/pull/2167/files#r4952800>
. — Reply to this email directly or view it on GitHub<
https://github.com/matplotlib/matplotlib/pull/2167/files#r4952860> .

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2167/files#r4952906
.