Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

DOC: change gridspec tutorial to arranging_axes tutorial#21631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

jklymak
Copy link
Member

@jklymakjklymak commentedNov 14, 2021•
edited
Loading

PR Summary

/tutorials/intermediate/gridspec was pretty stale, in particular users almost never need to access gridspec directly anymore withsubplot_mosaic andsubfigures providing higher-level interfaces to those features. I also moved the tutorial to a new namearranging_axes instead ofgridspec since the tutorial is now more general.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (installflake8-docstrings and runflake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

@jklymakjklymak changed the titleDOC: modernize gridspec tutorialDOC: change gridspec tutorial to arranging_axes tutorialNov 14, 2021
@jklymak
Copy link
MemberAuthor

I have to fix a link but this will likely require other revision so I'll open to review.

@jklymakjklymak marked this pull request as ready for reviewNovember 14, 2021 13:16
@jklymakjklymak added Documentation topic: geometry managerLayoutEngine, Constrained layout, Tight layout labelsNov 14, 2021
@jklymakjklymakforce-pushed thedoc-update-gridspec-tutorial branch fromfbd9161 tof99590cCompareNovember 14, 2021 20:41
Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@jklymak It's great that you take this on! 👍 I've only managed to review the "High-level methods for making grids", but I think that part of feedback is already actionable and you can respond before/while I review the rest.

story645 reacted with thumbs up emoji
@jklymakjklymakforce-pushed thedoc-update-gridspec-tutorial branch from286efc0 to63054c2CompareNovember 15, 2021 09:33
Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm happy with the High-level part! :) will have a look at the other topics later.

@jklymakjklymakforce-pushed thedoc-update-gridspec-tutorial branch from51f364a to01098acCompareNovember 16, 2021 16:22
@jklymakjklymakforce-pushed thedoc-update-gridspec-tutorial branch fromf35a501 to524e27fCompareNovember 17, 2021 08:21
@jklymakjklymak added this to thev3.5-doc milestoneNov 17, 2021
@jklymakjklymakforce-pushed thedoc-update-gridspec-tutorial branch from9a7e915 to94c643bCompareNovember 18, 2021 09:10
@jklymakjklymakforce-pushed thedoc-update-gridspec-tutorial branch from94c643b to4e3cdceCompareNovember 19, 2021 07:18
@jklymakjklymakforce-pushed thedoc-update-gridspec-tutorial branch fromc00b89a to8be6678CompareNovember 23, 2021 10:10
Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is good modulo handling@QuLogic's comments.

@jklymakjklymakforce-pushed thedoc-update-gridspec-tutorial branch from8be6678 to5c1f4d2CompareNovember 24, 2021 08:32
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@jklymakjklymakforce-pushed thedoc-update-gridspec-tutorial branch from5c1f4d2 to81440beCompareNovember 24, 2021 09:34
@QuLogicQuLogic merged commit756d1d4 intomatplotlib:mainNov 24, 2021
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.5.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -m1 756d1d462052db5fc115faf6535427b72344b193
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #21631: DOC: change gridspec tutorial to arranging_axes tutorial'
  1. Push to a named branch:
git push YOURFORK v3.5.x:auto-backport-of-pr-21631-on-v3.5.x
  1. Create a PR against branch v3.5.x, I would have named this PR:

"Backport PR#21631 on branch v3.5.x (DOC: change gridspec tutorial to arranging_axes tutorial)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@jklymakjklymak deleted the doc-update-gridspec-tutorial branchNovember 24, 2021 21:25
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.5.0-docgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -m1 756d1d462052db5fc115faf6535427b72344b193
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #21631: DOC: change gridspec tutorial to arranging_axes tutorial'
  1. Push to a named branch:
git push YOURFORK v3.5.0-doc:auto-backport-of-pr-21631-on-v3.5.0-doc
  1. Create a PR against branch v3.5.0-doc, I would have named this PR:

"Backport PR#21631 on branch v3.5.0-doc (DOC: change gridspec tutorial to arranging_axes tutorial)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@jklymak
Copy link
MemberAuthor

I guess this doesn't need to be back ported...

@jklymakjklymak modified the milestones:v3.5-doc,v3.6.0Nov 25, 2021
jklymak pushed a commit to jklymak/matplotlib that referenced this pull requestNov 27, 2021
…tutorialDOC: change gridspec tutorial to arranging_axes tutorial
jklymak pushed a commit to jklymak/matplotlib that referenced this pull requestNov 27, 2021
…tutorialDOC: change gridspec tutorial to arranging_axes tutorial
jklymak pushed a commit to jklymak/matplotlib that referenced this pull requestNov 27, 2021
…tutorialDOC: change gridspec tutorial to arranging_axes tutorial
QuLogic added a commit that referenced this pull requestNov 27, 2021
QuLogic added a commit to QuLogic/matplotlib that referenced this pull requestDec 1, 2021
This PR renames a tutorial, and thus needs to updtae a link in a .pyfile. Changes to .py files have no effect on the -doc branch, because itis run against the released version, so this breaks the build since theold link is gone.This reverts commit37131e9.
QuLogic added a commit to QuLogic/matplotlib that referenced this pull requestDec 1, 2021
This PR renames a tutorial, and thus needs to updtae a link in a .pyfile. Changes to .py files have no effect on the -doc branch, because itis run against the released version, so this breaks the build since theold link is gone.This reverts commit37131e9.
QuLogic added a commit that referenced this pull requestDec 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
Documentationtopic: geometry managerLayoutEngine, Constrained layout, Tight layout
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

3 participants
@jklymak@QuLogic@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp