Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Check for images added-and-modified in a same PR#21593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
anntzer merged 1 commit intomatplotlib:mainfromanntzer:doubleimg
Nov 14, 2021

Conversation

anntzer
Copy link
Contributor

PR Summary

... as is currently the case in#21562.

As in#21359, this currently contains two additional commits at the top that should cause CI to fail; I will edit these commits out of existence once this PR is approved.

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogicQuLogic added this to thev3.6.0 milestoneNov 11, 2021
dstansby
dstansby previously requested changesNov 13, 2021
Copy link
Member

@dstansbydstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is an approval, but I'll stick request changes on it so it doesn't accidentally get merged before you remove the test figure.

@jklymak
Copy link
Member

@anntzer feel free to self merge when you have the image squashed out....

dstansby and timhoffm reacted with thumbs up emoji

@anntzeranntzerforce-pushed thedoubleimg branch 2 times, most recently from90be1ae to5f3b113CompareNovember 14, 2021 20:47
@anntzeranntzer merged commit02f093b intomatplotlib:mainNov 14, 2021
@anntzeranntzer deleted the doubleimg branchNovember 14, 2021 20:57
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm left review comments

@QuLogicQuLogicQuLogic approved these changes

@dstansbydstansbydstansby left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

5 participants
@anntzer@jklymak@QuLogic@timhoffm@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp